-
Notifications
You must be signed in to change notification settings - Fork 217
feat: add health check probes for k8s liveness and readiness #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implement health probe endpoints following k8s best practices: - Add LiveChecker and ReadyChecker interfaces to service framework - Implement IsLive() and IsReady() methods in PowerMonitor using atomic operations - Create HealthProbe service with /probe/livez and /probe/readyz endpoints - Update K8s daemonset to use new health endpoints instead of /metrics - unit tests for health check Signed-off-by: Vimal Kumar <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2331 +/- ##
==========================================
- Coverage 90.70% 90.67% -0.04%
==========================================
Files 44 45 +1
Lines 4852 4954 +102
==========================================
+ Hits 4401 4492 +91
- Misses 361 369 +8
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📊 Profiling reports are ready to be viewed
💻 CPU Comparison with base Kepler💾 Memory Comparison with base Kepler (Inuse)💾 Memory Comparison with base Kepler (Alloc)⬇️ Download the Profiling artifacts from the Actions Summary page 📦 Artifact name: 🔧 Or use GitHub CLI to download artifacts: gh run download 18272226677 -n profile-artifacts-2331 |
|
📊 Profiling reports are ready to be viewed
💻 CPU Comparison with base Kepler💾 Memory Comparison with base Kepler (Inuse)💾 Memory Comparison with base Kepler (Alloc)⬇️ Download the Profiling artifacts from the Actions Summary page 📦 Artifact name: 🔧 Or use GitHub CLI to download artifacts: gh run download 18272242061 -n profile-artifacts-2331 |
Implement health probe endpoints following k8s best practices: